Repository navigation
Conversation
The next up countdown and the ended event both advance to the next episode after awaiting reportStop. The second one returns from it at once and loads the next episode, then the first resumes and tears that player down mid prepare, so the load spins until the 2 minute timeout. Refs Moonfin-Client#483 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Build SuccessfulAll platform builds and the test suite passed. You can download the artifacts below.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
When the next up countdown runs out within about a second and a half of the episode ending, the next episode spins for two minutes and then fails with "Stream preparation timed out" (#483). The countdown and the ended event both advance to the next episode: each awaits
reportStop, closes the player and callsonPlayNext. The second one gets back fromreportStopstraight away and loads the next episode. Then the first one resumes and closes that new player while it is still preparing. ItsonPlayNextasks for the same episode, so nothing loads it again.Both paths now read
loadGenerationRefbeforereportStopand return if a new load started in the meantime, so whichever one finishes second leaves the new player alone.WebOSPlayer.jshas noloadGenerationRef, so itshandleEndedchecksprevItemIdRefagainst its item instead. ItsonPlayNextWithCleanupcloses nothing after the stop, and a late call only asks for the episode that is already playing, so it stays as it is.Related Issues
Type of Change
Changes Made
TizenPlayer.js:onPlayNextWithCleanupandhandleEndedreturn afterreportStopifloadGenerationRefmoved while it was pending.WebOSPlayer.js:handleEndedreturns afterreportStopifprevItemIdRefis no longer its item.Platform
Testing
I Manually tested on a Samsung TU43DU7105KXXC running Tizen 9, from a
Moonfin_Tizen_Regular_2.9.0.wgtbuilt off mainb67705e7with this branch merged in. That build also carried other open PRs. Result: when next up and the end of the episode land together, the next episode starts playing instead of hanging.enact lint packages/app/srcis clean andnpm run lint:cssis OK.enact teston this branch: 2260 passed, 3 failed. The three failures (personCredits×2,seerrBadges×1) hardcode US English date and currency output and fail on this machine'sca-ESlocale, so they're unrelated to this change.npm run build:tizenbuilds from this branch.Test Steps
Screenshots (if applicable)
None attached. This is a timing fix with no visible UI change.
Checklist
npm run build:tizenbuilds from this branchenact lintclean🤖 Generated with Claude Code