Skip to content

Anime Markers for all languages fix - #312

Open
MasterOfKay wants to merge 1 commit into
Moonfin-Client:masterfrom
MasterOfKay:fix/anime-markers-match-by-id
Open

MasterOfKay wants to merge 1 commit into
Moonfin-Client:masterfrom
MasterOfKay:fix/anime-markers-match-by-id

Conversation

@MasterOfKay

Copy link
Copy Markdown
Contributor

…d to englisch for mapping

Pull Request

Summary

Fixes Bug in Anime detection from diffrent language libarys where the id passing was not correct.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • API / endpoint change
  • Settings schema change
  • Documentation update
  • Build/CI change
  • Other (describe):

Area

  • Settings sync / profiles
  • Admin defaults / config page
  • Ratings (MDBList / TMDB)
  • Notifications / Push (FCM / relay)
  • Seerr integration
  • Games / Emulators
  • Custom home rows
  • Web Client (Go to Moonfin-Core repo)
  • Other / shared

Changes Made

List the key changes included in this PR.

  • ID's from detected animes get now parsed correctly to a MAL ID if the Anime Name is not englisch or romanji
  • reworked imdb id's passing as imdb hase Seasons as list instead of seasons

Client Impact

Does this need matching changes in a client repo (Core, Smart-TV, Roku)?

  • No client changes needed
  • Companion client PR(s) required, linked here:
  • New setting keys added. List each key and confirm it matches the client key exactly, including casing:

Compatibility

  • Change to the settings profile is additive only, no renamed or removed properties
  • New properties use the same type the client sends (a client bool maps to bool?, an int to int?)
  • Migration added for any renamed or removed settings
  • Older clients still work, unknown fields are ignored and no keys were removed

Testing

Describe how this change was tested.

  • Built the plugin and deployed to a Jellyfin server
  • Verified against a live client (which one:)
  • Manual testing completed (Two from the discord server also tested it)
  • Not tested (explain why):

Test Steps

  1. Loaded the new plugin version
  2. Scanned Anime Libarys
  3. Saw Animes that had fillers now marked as filler etc.

Screenshots (if applicable)

Include config page screenshots or request/response samples where relevant.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced
  • Any new setting keys match the client-side keys exactly

@github-actions github-actions Bot added Bug Something isn't working Ratings labels Oct 4, 2026
@MasterOfKay MasterOfKay changed the title IDs fixed so they are being used and international Titels get switche… Anime Markers for all languages fix Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Build Successful

Both plugins compiled against .NET 8, and both test suites passed.

Property Value
Commit bf51046
Jellyfin ABI 10.10.0.0
Emby version 2.3.0.0
Workflow Build #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Ratings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant