Skip to content

test: add assertions to RelationService unit tests#54

Merged
Mom0aut merged 1 commit into
Mom0aut:masterfrom
nova1128:improve/relation-service-test-assertions
May 29, 2026
Merged

test: add assertions to RelationService unit tests#54
Mom0aut merged 1 commit into
Mom0aut:masterfrom
nova1128:improve/relation-service-test-assertions

Conversation

@nova1128
Copy link
Copy Markdown
Contributor

Describe your changes

Added assertions to the existing unit tests in RelationServiceTest.java
which previously had no assertions. Also mocked the save() return value
in createRelation test to properly verify the result.

Issue ticket number and link

Closes #4
#4

Checklist before requesting a review

  • [x ] I have performed a self-review of my code
  • [ x] If it is a core feature, I have added thorough tests.
  • I have made corresponding changes to the documentation
  • [ x] I used the given Project Style Guide

@nova1128
Copy link
Copy Markdown
Contributor Author

this is my first contribution so maybe it will fall shaort on some paramters i would request uh to suggest me if i have done something wrong

@Mom0aut
Copy link
Copy Markdown
Owner

Mom0aut commented May 29, 2026

Looks good to me, thanks for your contribution 🚀

@Mom0aut Mom0aut merged commit 4c3c08c into Mom0aut:master May 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More Unit Test Coverage

2 participants