test: add assertions to RelationService unit tests#54
Merged
Mom0aut merged 1 commit intoMay 29, 2026
Merged
Conversation
Contributor
Author
|
this is my first contribution so maybe it will fall shaort on some paramters i would request uh to suggest me if i have done something wrong |
Mom0aut
approved these changes
May 29, 2026
Owner
|
Looks good to me, thanks for your contribution 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added assertions to the existing unit tests in RelationServiceTest.java
which previously had no assertions. Also mocked the save() return value
in createRelation test to properly verify the result.
Issue ticket number and link
Closes #4
#4
Checklist before requesting a review