feat(feedback): add categories and UI element picker#108
Merged
Conversation
Signed-off-by: Justin Levine <20596508+jal-co@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Triaging feedback needs a type, and UI reports need the exact element instead of a prose guess.
How
lib/element-picker.tsoverlays a crosshair mode: hover highlights the element, click captures a compact descriptor (bounded CSS path, visible text snippet, viewport rect), and Escape cancels. The dialog goes non-modal and invisible while picking, then restores with a removable element chip. The server function validates the category against a fixed set and caps every element field before embedding.Testing
pnpm --filter web typecheckpnpm --filter web test(83 passed)pnpm --filter web buildpnpm --filter web build-storybookgit diff --checkScreenshots
/tmp/feedback-element-picked.png