fix(tools): repair site previews and image redirects#101
Merged
Conversation
Signed-off-by: Justin Levine <20596508+jal-co@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
redirect: "error"image fetching with bounded manual redirectsWhy
Cloudflare Workers does not implement
fetch(..., { redirect: "error" }), so submitting a tool with an Open Graph image surfaced the raw edge-runtime error shown in the report. The old opaque-origin iframe also caused sites such as Shieldcn to throw when their runtime accessed local storage, leaving an error page in the preview.How
allow-same-originonly when the embedded site is cross-origin from Modulora; browser same-origin policy still blocks parent accessTesting
allow-scripts allow-same-originredirect: "manual"and invalid HTTP redirect destinations fail before fetchinggit diff --checkScreenshots
/Users/justin/Library/Application Support/CleanShot/media/media_uYa5nHHQTA/CleanShot 2026-07-15 at 15.51.22@2x.png/tmp/tool-editor-preview-fixed.png/tmp/tool-editor-mobile-fixed.png/tmp/external-preview-story.png