Repository navigation
Fix Windows desktop build: NSIS only (skip WiX MSI for alpha) - #56
Merged
Merged
Conversation
WiX rejects non-numeric semver pre-releases like 0.1.0-alpha.1. Bundle NSIS only on Windows so alpha versions package successfully. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows Release/Desktop builds failed because WiX MSI rejects non-numeric semver pre-releases (
0.1.0-alpha.1).Fix
--bundles nsisin CI;tauri.conf.jsontargets excludemsi)0.1.0-alpha.1as the app version (NSIS supports full semver)Re-test
After merge, re-run Actions → Release (or Desktop Installers with Windows).