Fix impact-graph MiniMap so it draws the node overview - #8
Merged
Merged
Conversation
React Flow only paints MiniMap rects when nodes declare width/height. Custom load nodes never set those, so the overview was an empty mask. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe React Flow graph now uses fixed node dimensions and a configured minimap with theme-aware styling. The screenshot test waits for minimap content, and the HTML entrypoint references regenerated assets. ChangesReact Flow visualization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The impact graph already mounted React Flow’s MiniMap, but the overview was an empty gray mask. Custom load nodes never declared
width/height, and MiniMap reads those off the user node — not the measured DOM box — so it skipped every node.What changed
.react-flow__minimap-nodein the Playwright graph screenshot flow.Tests
cd ui && npm test && npm run build. Playwrighttests/e2e/test_ui_screenshots.pypassed; README screenshots regenerated.Summary by CodeRabbit
New Features
Style
Bug Fixes