Richer node inspector after OSS PR graph validation - #22
Conversation
OSS PR graphs were consistent (no dangling edges) but hid N+1/lookup hits and Django field kwargs. Extract null/blank/default/max_length and docstrings, and render degree plus edge-kind summaries on the selected node. Co-authored-by: zord.lack.net <zord.lack.net@gmail.com>
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (3)
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughWalkthroughThe change adds Django field constraints and docstrings to extracted metadata. It expands graph inspection with edge degrees, grouped edge kinds, path summaries, and formatted object facts. The frontend renders these details, updates bundled assets, and adds unit, layout, and E2E coverage. ChangesMetadata Extraction and Graph Inspection
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This PR enriches the node inspector and Django graph metadata while updating the index revision; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant DjangoExtractor
participant GraphData
participant inspectNode
participant GraphInspector
DjangoExtractor->>GraphData: attach constraints and documentation
GraphData->>inspectNode: provide node facts and graph links
inspectNode->>inspectNode: calculate degrees and path summary
inspectNode->>GraphInspector: render inspection metadata
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Adversarial review of the inspector extras: do not store a field default of None, attach Ninja/FastAPI docstrings, copy live null/blank constraints from the Django boot overlay, and omit the path line when a node has no neighbors in the current graph. Co-authored-by: zord.lack.net <zord.lack.net@gmail.com>
The first edge in DOM order can stay visibility:hidden (unmeasured or clipped) while other edges are on screen, which made CI time out even when the graph had painted. Co-authored-by: zord.lack.net <zord.lack.net@gmail.com>
Ran Loadpath against 10 public Django (and Django+frontend) pull requests from distinct repos, then used those graphs to extend the selected-node inspector.
OSS graph checks (all 10)
file_paths exist on disk.nplusone,lookups,signal/sender,decorators, field kwargs.Inspector
N in · M out) and an edge-kind load-path summary.null,blank,default,max_length,max_digits,decimal_places,primary_key,help_text,choices.Review follow-up
default=Noneas a field fact.null/blank/max_length(and related) constraints from the Django boot overlay.INDEX_REVISIONbumped to13so incremental indexes pick up the extra-identity change.Summary by CodeRabbit
New Features
Bug Fixes
nullandblankvalues.Tests