Answer the temporal aggregates as MobilityDB answers them - #58
Merged
estebanzimanyi merged 1 commit intoSep 28, 2026
Merged
Conversation
GeneratedSurfaceTest runs tCount, tSum, tMinAgg, tMaxAgg and mergeAgg over three temporal integers, and tAndAgg and tOrAgg over two temporal booleans, each value in a partition of its own, so the transition runs in every partition and the combine joins the partial states the shuffle carries between them. Each answer is the text MobilityDB answers for the same aggregate over the same values in UTC. tSum over a temporal integer and a temporal float in two partitions raises the refusal of a mix of types. Measured. Against JMEOS with the generated aggregates, the libmeos of MobilityDB 510c3184f6 and the catalog derived from its installed headers, the suite runs 20 tests, all passing; with the combine of the aggregator dropped, tCount answers null and the test fails. Why. The generated surface registers the aggregates, and a partial state that crosses executors is the one path the scalar tests never take.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSurfaceTest runs tCount, tSum, tMinAgg, tMaxAgg and mergeAgg over
three temporal integers, and tAndAgg and tOrAgg over two temporal booleans,
each value in a partition of its own, so the transition runs in every
partition and the combine joins the partial states the shuffle carries
between them. Each answer is the text MobilityDB answers for the same
aggregate over the same values in UTC. tSum over a temporal integer and a
temporal float in two partitions raises the refusal of a mix of types.
Measured. Against JMEOS with the generated aggregates, the libmeos of
MobilityDB 510c3184f6 and the catalog derived from its installed headers,
the suite runs 20 tests, all passing; with the combine of the aggregator
dropped, tCount answers null and the test fails.
Why. The generated surface registers the aggregates, and a partial state
that crosses executors is the one path the scalar tests never take.