Say the generator is staged, because it is - #51
Merged
estebanzimanyi merged 1 commit intoAug 31, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
`GENERATION.md` calls `codegen_jvm.py` "the single generator vendored identically by every JVM binding", and the `pom.xml` comment calls the catalog "vendored". Neither is: `.gitignore` lists `tools/meos-idl.json`, `tools/codegen_jvm.py` and `tools/codegen_spark_udfs.py`, and `maven.yml` copies all three in — the catalog from the provision-meos action, the two generator files from a JMEOS checkout. The workflow says as much in its own comment two files away. The distinction is the point rather than a nicety. Every symbol the generator emits is a call into the `functions.GeneratedFunctions` the jar carries, so the generator and the surface it binds are one unit, and JMEOS owns it. A copy in this tree goes stale the moment that surface folds an out-parameter or widens a return, which is what three copies did before JMEOS took ownership: they drifted by 202 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GENERATION.mdcallscodegen_jvm.py"the single generator vendored identicallyby every JVM binding", and the
pom.xmlcomment calls the catalog "vendored".Neither is:
.gitignoreliststools/meos-idl.json,tools/codegen_jvm.pyandtools/codegen_spark_udfs.py, andmaven.ymlcopies all three in — the catalogfrom the provision-meos action, the two generator files from a JMEOS checkout. The
workflow says as much in its own comment two files away.
The distinction is the point rather than a nicety. Every symbol the generator
emits is a call into the
functions.GeneratedFunctionsthe jar carries, so thegenerator and the surface it binds are one unit, and JMEOS owns it. A copy in this
tree goes stale the moment that surface folds an out-parameter or widens a return,
which is what three copies did before JMEOS took ownership: they drifted by 202
lines.