Build the JMEOS jar the way its own script defines it - #30
Merged
estebanzimanyi merged 1 commit intoAug 31, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
JMEOS carries `tools/regen-from-catalog.sh`, the single runnable definition of that build: it stages the catalog and libmeos, and jmeos-core's generate-sources emits GeneratedFunctions from the catalog. `tools/refresh-from-master.sh` reaches the same script through the shared chain, so calling it from the workflow leaves the CI path and the by-hand path unable to drift. The workflow named `-Dmaven.test.skip=true`, which skips test COMPILATION as well as execution, so a JMEOS whose test sources do not compile against the catalog this job derived still produced a green jar step. Naming LIBMEOS runs the FFI suite against the libmeos the job just built — 1792 tests, 0 failures, 0 errors, 0 skipped — which is what tells a jar that merely compiles from one whose generated surface answers. `tools/refresh-from-master.sh` no longer offers `--skip-tests`: the chain it forwards to carries no such option, so the line documented a flag that is refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JMEOS carries
tools/regen-from-catalog.sh, the single runnable definition ofthat build: it stages the catalog and libmeos, and jmeos-core's
generate-sources emits GeneratedFunctions from the catalog.
tools/refresh-from-master.shreaches the same script through the sharedchain, so calling it from the workflow leaves the CI path and the by-hand path
unable to drift.
The workflow named
-Dmaven.test.skip=true, which skips test COMPILATION aswell as execution, so a JMEOS whose test sources do not compile against the
catalog this job derived still produced a green jar step. Naming LIBMEOS runs
the FFI suite against the libmeos the job just built — 1792 tests, 0 failures,
0 errors, 0 skipped — which is what tells a jar that merely compiles from one
whose generated surface answers.
tools/refresh-from-master.shno longer offers--skip-tests: the chain itforwards to carries no such option, so the line documented a flag that is
refused.