Generate the array-set relationships instead of marshalling them by hand - #29
Merged
Merged
Conversation
The refresh composed ${SKIP_TESTS:+-DskipTests} into the build command, and the shared
script left that variable set to 0 rather than unset, so the flag was always passed. It
skips the run and not the compilation, so the refresh reported the binding as refreshed
while its suite had not executed once.
The build command no longer composes it, and the shared script no longer offers the
option to compose.
The NxN kernels answer which element of one array relates to which of the other, taking (TYPE **, int) argument pairs and writing the count through an out-parameter. The facade forwards them in their C shape, so a caller had to build the native arrays, allocate the count and decode the flattened pairs, and MeosSetSetJoin did that by hand for three of the twelve. The catalog states the shape: arrayReturn.groupSize marks the flattened index-pair return, outParams names the count and the parallel span-set array, and sqlfn gives the name the SQL surface answers to. The facade emits a folded form from those, beside the forwarder rather than in place of it, so the canonical dialect keeps its C shape and the Java form is the additive one. It covers all twelve kernels under their canonical names, eDwithinPairs through tDisjointPairs, and the buffers stay reachable across the call. The shared runtime carries the marshalling and the free, and is public, so a consumer reads it directly. MeosSetSetJoin is gone and the package holds generated code only.
estebanzimanyi
force-pushed
the
regen/kafka-nxn
branch
from
August 31, 2026 12:20
b2352f4 to
08ea1a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NxN kernels answer which element of one array relates to which of the other, taking
(TYPE **, int) argument pairs and writing the count through an out-parameter. The facade
forwards them in their C shape, so a caller had to build the native arrays, allocate the
count and decode the flattened pairs, and MeosSetSetJoin did that by hand for three of
the twelve.
The catalog states the shape: arrayReturn.groupSize marks the flattened index-pair
return, outParams names the count and the parallel span-set array, and sqlfn gives the
name the SQL surface answers to. The facade emits a folded form from those, beside the
forwarder rather than in place of it, so the canonical dialect keeps its C shape and the
Java form is the additive one. It covers all twelve kernels under their canonical names,
eDwithinPairs through tDisjointPairs, and the buffers stay reachable across the call.
The shared runtime carries the marshalling and the free, and is public, so a consumer
reads it directly. MeosSetSetJoin is gone and the package holds generated code only.