Ask for the pose angle under the one name that answers it - #28
Merged
estebanzimanyi merged 1 commit intoAug 31, 2026
Merged
Conversation
MobilityDB answers a pose orientation angle under one name across the pose, temporal pose and rigid geometry families, and pose_rotation was the redundant twin it removed in favour of pose_yaw. The smoke test still called the removed name, so the binding stopped compiling against a libmeos built from master. The test asks for pose_yaw, which is what a 2D pose's single stored angle is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MobilityDB answers a pose orientation angle under one name across the pose, temporal
pose and rigid geometry families, and pose_rotation was the redundant twin it removed
in favour of pose_yaw. The smoke test still called the removed name, so the binding
stopped compiling against a libmeos built from master.
The test asks for pose_yaw, which is what a 2D pose's single stored angle is called.