Advance the MEOS commit and read the space splits and asMVTGeom through their out-parameters - #422
Merged
estebanzimanyi merged 2 commits intoSep 30, 2026
Conversation
MEOS returns the fragments of tgeo_space_split and tgeo_space_time_split and reports whether tpoint_as_mvtgeom has a representation in the tile, handing the bins, the times and the counts back through out-parameters, as its other functions returning parallel arrays do. The spaceSplit, spaceTimeSplit and asMVTGeom functions of the extension read them that way. Witness: at MEOS 60ed6ea3c8, which the refresh of the generated surface pins, src/geo/tgeompoint.cpp stops at "'MvtGeom' was not declared in this scope", "'SpaceTimeSplit' was not declared in this scope" and "'SpaceSplit' was not declared in this scope", since MEOS no longer declares the three structs it returned by value. It now compiles. Measured: the release build against the MEOS headers vcpkg installs at that commit is clean, and the full test suite passes, 3,058 assertions in 107 test cases, among them 058b_tpoint_split with 11, 058c_tpoint_split_lateral with 21 and 076_asmvtgeom_geomeasure with 6. Why: the extension calls MEOS through the declarations of the commit it pins, and a tile answer that MEOS reports as absent is an absent row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance the MEOS commit and regenerate the UDF surface
Read the space splits and asMVTGeom through their out-parameters
MEOS returns the fragments of tgeo_space_split and tgeo_space_time_split and
reports whether tpoint_as_mvtgeom has a representation in the tile, handing
the bins, the times and the counts back through out-parameters, as its other
functions returning parallel arrays do. The spaceSplit, spaceTimeSplit and
asMVTGeom functions of the extension read them that way.
Witness: at MEOS 60ed6ea3c8, which the refresh of the generated surface
pins, src/geo/tgeompoint.cpp stops at "'MvtGeom' was not declared in this
scope", "'SpaceTimeSplit' was not declared in this scope" and "'SpaceSplit'
was not declared in this scope", since MEOS no longer declares the three
structs it returned by value. It now compiles.
Measured: the release build against the MEOS headers vcpkg installs at that
commit is clean, and the full test suite passes, 3,058 assertions in 107
test cases, among them 058b_tpoint_split with 11, 058c_tpoint_split_lateral
with 21 and 076_asmvtgeom_geomeasure with 6.
Why: the extension calls MEOS through the declarations of the commit it
pins, and a tile answer that MEOS reports as absent is an absent row.