Answer a value MEOS writes through a pointer to a pointer - #29
Merged
estebanzimanyi merged 1 commit intoSep 3, 2026
Merged
Conversation
Some accessors answer a value that is itself a MEOS value: `set_value_n` on a set of geometries writes a `GSERIALIZED **`, `ttext_value_at_timestamptz` a `text **`, and their kin the same for a circular buffer, a network point, a pose and a jsonb. The buffer holds the ADDRESS of the value rather than the value, so the reader takes that address out of it and wraps it in the class the model gives the type — the same wrap a return of that type gets. 19 accessors reach the object layer that way, so `GeomSet.ValueN` answers a `Geo` and `TText.ValueAtTimestamptz` a `Text`, each null where MEOS says the value does not exist. 1190 methods against 1171, 105 deferred against 124. Two tests read both answers: a geometry set answers the geometry at an index and null past the end, and a temporal text answers its value inside its span and null outside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some accessors answer a value that is itself a MEOS value:
set_value_non aset of geometries writes a
GSERIALIZED **,ttext_value_at_timestamptzatext **, and their kin the same for a circular buffer, a network point, apose and a jsonb. The buffer holds the ADDRESS of the value rather than the
value, so the reader takes that address out of it and wraps it in the class the
model gives the type — the same wrap a return of that type gets. 19 accessors
reach the object layer that way, so
GeomSet.ValueNanswers aGeoandTText.ValueAtTimestamptzaText, each null where MEOS says the value doesnot exist. 1190 methods against 1171, 105 deferred against 124.
Two tests read both answers: a geometry set answers the geometry at an index
and null past the end, and a temporal text answers its value inside its span
and null outside.