Build the core jar from the libraries JMEOS runs on, not from the tools that build it - #119
Open
estebanzimanyi wants to merge 1 commit into
Open
estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
…ls that build it The dependencies of jmeos-core are the libraries its code and tests import: slf4j-api 1.7.36, which MeosErrorHandler logs through, is one of them, and maven-plugin-plugin, jacoco-maven-plugin and junit are not. The two plugins are configured as build plugins, and the tests run on junit-jupiter in the test scope; no source imports JUnit 4, Maven or JaCoCo. Witness. The plugins and JUnit 4 sat in the compile scope, so the shaded jar carried Maven, Aether, Plexus, JaCoCo and JUnit 4 along with JMEOS: 88 artifacts, 13 groups of overlapping resources, and slf4j-api only as a dependency of maven-plugin-plugin. Measured. Against the catalog and libmeos of MobilityDB 8a23781e4c with MEOS-API 8dddf59, the shade step includes 25 artifacts and reports 3 groups of overlapping resources. JMEOS-fat.jar holds no class of org.apache.maven, org.jacoco, org.codehaus.plexus, org.eclipse.aether or JUnit 4, and 38 entries of org.slf4j. The suites run 106 and 1,810 tests, all passing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependencies of jmeos-core are the libraries its code and tests import: slf4j-api 1.7.36,
which MeosErrorHandler logs through, is one of them, and maven-plugin-plugin,
jacoco-maven-plugin and junit are not. The two plugins are configured as build plugins, and the
tests run on junit-jupiter in the test scope; no source imports JUnit 4, Maven or JaCoCo.
Witness. The plugins and JUnit 4 sat in the compile scope, so the shaded jar carried Maven,
Aether, Plexus, JaCoCo and JUnit 4 along with JMEOS: 88 artifacts, 13 groups of overlapping
resources, and slf4j-api only as a dependency of maven-plugin-plugin.
Measured. Against the catalog and libmeos of MobilityDB 8a23781e4c with MEOS-API 8dddf59,
the shade step includes 25 artifacts and reports 3 groups of overlapping resources.
JMEOS-fat.jar holds no class of org.apache.maven, org.jacoco, org.codehaus.plexus,
org.eclipse.aether or JUnit 4, and 38 entries of org.slf4j. The suites run 106 and 1,810
tests, all passing.