Build the value set of a temporal with the set constructor of its base type - #117
Merged
estebanzimanyi merged 1 commit intoSep 30, 2026
Conversation
…e type
The value_set of TFloat, TText, TGeomPoint and TGeogPoint passes the array the MEOS
tfloat_values, ttext_values or tgeo_values returns, and its count, to floatset_make,
textset_make or geoset_make, and wraps the set in FloatSet, TextSet, GeometrySet or
GeographySet. The spatial ones round the set to their precision argument with set_round.
Witness. Each appended to a StringBuilder declared null, so each threw a
NullPointerException on any input. TText returned an anonymous Set whose inner was the
text array itself, and the spatial ones rebuilt their set from point text, which carries
no SRID.
Measured. Against the catalog and libmeos of MobilityDB 8a23781e4c with MEOS-API 8dddf59,
the testValueSet tests of TFloatTest, TTextTest, TGeomPointTest and TGeogPointTest read
{1.5, 2.5}, {"AAA", "BBB"}, SRID=3812;{"POINT(1.12 1)", "POINT(2 2)"} from a point at
1.123456 rounded to 2 digits, and SRID=4326;{"POINT(1 1)", "POINT(2 2)"}. The build succeeds
and the suites run 106 and 1,810 tests, all passing.
Why. MEOS builds a set from the values of its base type, and a set built that way holds
every value exactly, the SRID included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value_set of TFloat, TText, TGeomPoint and TGeogPoint passes the array the MEOS
tfloat_values, ttext_values or tgeo_values returns, and its count, to floatset_make,
textset_make or geoset_make, and wraps the set in FloatSet, TextSet, GeometrySet or
GeographySet. The spatial ones round the set to their precision argument with set_round.
Witness. Each appended to a StringBuilder declared null, so each threw a
NullPointerException on any input. TText returned an anonymous Set whose inner was the
text array itself, and the spatial ones rebuilt their set from point text, which carries
no SRID.
Measured. Against the catalog and libmeos of MobilityDB 8a23781e4c with MEOS-API 8dddf59,
the testValueSet tests of TFloatTest, TTextTest, TGeomPointTest and TGeogPointTest read
{1.5, 2.5}, {"AAA", "BBB"}, SRID=3812;{"POINT(1.12 1)", "POINT(2 2)"} from a point at
1.123456 rounded to 2 digits, and SRID=4326;{"POINT(1 1)", "POINT(2 2)"}. The build succeeds
and the suites run 106 and 1,810 tests, all passing.
Why. MEOS builds a set from the values of its base type, and a set built that way holds
every value exactly, the SRID included.