Split a temporal number by value and time from the start it is given - #116
Merged
estebanzimanyi merged 1 commit intoSep 30, 2026
Conversation
TNumber.value_time_split converts its duration whatever its start, takes the default time origin, Monday 3 January 2000, only when no start is given, and reads a given start as a LocalDateTime or as its text. It passes NULL for the value and time bins, which it does not return. Witness. With a start given, the method left its duration unconverted and MEOS refused the null interval, MeosInvalidArgError "Null pointer not allowed"; with no start, it threw a NullPointerException reading the start. Measured. Against the catalog and libmeos of MobilityDB 8a23781e4c with MEOS-API 8dddf59, testValueTimeSplit of TIntTest splits [1@2019-09-01, 5@2019-09-03] at value size 2 and a day: from midnight, and from the default origin, into the two days of the value 1 and the instant of the value 5; from noon into four fragments cut at noon on 1 and 2 September. The build succeeds and the suites run 106 and 1,806 tests, all passing. Why. The start a caller gives is the origin of the time buckets, as in TPoint.space_time_split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TNumber.value_time_split converts its duration whatever its start, takes the default time
origin, Monday 3 January 2000, only when no start is given, and reads a given start as a
LocalDateTime or as its text. It passes NULL for the value and time bins, which it does not
return.
Witness. With a start given, the method left its duration unconverted and MEOS refused the
null interval, MeosInvalidArgError "Null pointer not allowed"; with no start, it threw a
NullPointerException reading the start.
Measured. Against the catalog and libmeos of MobilityDB 8a23781e4c with MEOS-API 8dddf59,
testValueTimeSplit of TIntTest splits [1@2019-09-01, 5@2019-09-03] at value size 2 and a
day: from midnight, and from the default origin, into the two days of the value 1 and the
instant of the value 5; from noon into four fragments cut at noon on 1 and 2 September. The
build succeeds and the suites run 106 and 1,806 tests, all passing.
Why. The start a caller gives is the origin of the time buckets, as in
TPoint.space_time_split.