Leave out of the Spark generator the result structs MEOS does not declare - #115
Merged
estebanzimanyi merged 1 commit intoSep 30, 2026
Conversation
…lare INTERNAL in codegen_spark_udfs.py lists the base types the Spark surface leaves out; it names Match, the one result struct a MEOS function returns, and none of TimeSplit, FloatSplit, FloatTimeSplit, IntSplit, IntTimeSplit and MvtGeom. Witness. None of those six appears as a return or parameter type in the catalog of MobilityDB 1f2769e1c5 with MEOS-API c663adc, nor in its meos/include headers; Match types 8 returns and parameters there. Measured. Over that catalog and the JMEOS jar built from it, the generator writes the same 281 group classes, UdfMarshal and GeneratedSpatioTemporalUDFs byte for byte, and its report differs only in the output directory it names. Why. The list states what MEOS declares, and a name MEOS does not declare decides nothing.
estebanzimanyi
deleted the
codegen/spark-internal-drops-removed-structs
branch
September 30, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INTERNAL in codegen_spark_udfs.py lists the base types the Spark surface leaves out; it
names Match, the one result struct a MEOS function returns, and none of TimeSplit,
FloatSplit, FloatTimeSplit, IntSplit, IntTimeSplit and MvtGeom.
Witness. None of those six appears as a return or parameter type in the catalog of
MobilityDB 1f2769e1c5 with MEOS-API c663adc, nor in its meos/include headers; Match types 8
returns and parameters there.
Measured. Over that catalog and the JMEOS jar built from it, the generator writes the same
281 group classes, UdfMarshal and GeneratedSpatioTemporalUDFs byte for byte, and its
report differs only in the output directory it names.
Why. The list states what MEOS declares, and a name MEOS does not declare decides nothing.