Map a generated parameter by its catalog type alone - #113
Merged
estebanzimanyi merged 1 commit intoSep 30, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
FunctionsGenerator gives each parameter the Java type of its C type in the interface, in the wrapper and in the call, whatever the parameter's name. SIZE_PARAM_NAMES, which gave an int parameter named size or wkb_size the Java type long, is gone. Witness. A parameter declared int size maps to long size under the name rule, so a binding passes a 64-bit value where MEOS reads a 32-bit one. The test paramTypeFollowsCTypeNotName gives int size, int32_t wkb_size and size_t vsize the types int, int and long; under the name rule it reads long for the first two. Measured. Against the catalog and libmeos of MobilityDB a362004728 with MEOS-API 20efba81be, the 26 parameters named size or wkb_size are 21 size_t, 2 size_t *, 2 Datum and 1 double, none int, and GeneratedFunctions.java is byte for byte the one the name rule generates. The build succeeds and the suites run 106 and 1,799 tests, all passing. Why. The catalog states the C type of every parameter, and the binding is its projection: a name carries no type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FunctionsGenerator gives each parameter the Java type of its C type in the interface, in
the wrapper and in the call, whatever the parameter's name. SIZE_PARAM_NAMES, which gave an
int parameter named size or wkb_size the Java type long, is gone.
Witness. A parameter declared int size maps to long size under the name rule, so a binding
passes a 64-bit value where MEOS reads a 32-bit one. The test
paramTypeFollowsCTypeNotName gives int size, int32_t wkb_size and size_t vsize the types
int, int and long; under the name rule it reads long for the first two.
Measured. Against the catalog and libmeos of MobilityDB a362004728 with MEOS-API
20efba81be, the 26 parameters named size or wkb_size are 21 size_t, 2 size_t *, 2 Datum and
1 double, none int, and GeneratedFunctions.java is byte for byte the one the name rule
generates. The build succeeds and the suites run 106 and 1,799 tests, all passing.
Why. The catalog states the C type of every parameter, and the binding is its projection:
a name carries no type.