feat(wallet): support margin adjustments and maximum earn apy

[SeniorZhai]

No description provided.

[Copilot]

🟡 Changes recommended

Fragment recreation breaks adjustment callbacks, and reduction confirmation omits its liquidation-risk warning.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds perpetual-position margin adjustments and displays maximum Earn APY on wallet cards.

Changes:

• Adds add/reduce-margin flows, API integration, history support, and confirmation UI.
• Displays maximum APY for Earn accounts.
• Adds localized resources, icons, and tests.

File summaries

File	Description
WalletHomeEarnAccountTest.kt	Tests maximum APY calculation.
WalletHomeCashAccountTest.kt	Tests legacy cache compatibility.
WalletHomeAccountStateTest.kt	Updates Earn account fixture.
PerpsMarginAmountTest.kt	Tests margin calculations and validation.
PerpsOrderDaoTest.kt	Tests margin-order history queries.
OpenOrderRequestTest.kt	Tests adjustment serialization.
values/strings.xml	Adds English UI strings.
values-zh-rTW/strings.xml	Adds Traditional Chinese strings.
values-zh-rCN/strings.xml	Adds Simplified Chinese strings.
values-ru/strings.xml	Adds Russian strings.
values-ms/strings.xml	Adds Malay strings.
values-ko/strings.xml	Adds Korean strings.
values-ja/strings.xml	Adds Japanese strings.
values-in/strings.xml	Adds Indonesian strings.
values-es/strings.xml	Adds Spanish strings.
ic_perps_reduce_position.xml	Adds reduce-position icon.
ic_perps_reduce_margin.xml	Adds reduce-margin icon.
ic_perps_add_position.xml	Adds add-position icon.
ic_perps_add_margin.xml	Adds add-margin icon.
WalletHomeEarnAccount.kt	Calculates and formats maximum APY.
WalletHomeAccountCards.kt	Displays Earn APY badges.
PositionDetailPage.kt	Supports margin-order details.
PerpsMarketDetailPage.kt	Opens the adjustment menu.
PerpsMarginBottomSheetDialogFragment.kt	Implements margin adjustment UI and submission.
PerpsMarginAmount.kt	Provides margin calculation helpers.
PerpsConfirmBottomSheetDialogFragment.kt	Supports add-margin payment confirmation.
PerpsCloseBottomSheetDialogFragment.kt	Reuses confirmation flow for margin reduction.
PerpsAdjustBottomSheetDialogFragment.kt	Adds the adjustment action menu.
PerpsAddBottomSheetDialogFragment.kt	Refreshes position data and updates previews.
PerpetualViewModel.kt	Exposes margin adjustment API.
OpenedOrderItem.kt	Displays margin orders in history.
InputTextField.kt	Prevents invalid local input state.
PerpsOrderDao.kt	Includes margin orders in queries.
RouteService.kt	Defines the margin endpoint.
PerpsOrder.kt	Adds margin order types.
OpenOrderRequest.kt	Defines the adjustment request model.

Review details

Suppressed comments (1)

app/src/main/java/one/mixin/android/ui/home/web3/trade/perps/PerpsCloseBottomSheetDialogFragment.kt:580

• The reduction amount survives recreation in fragment arguments, but this callback does not. A restored confirmation therefore reaches showVerifyPinThenClose() with onMarginConfirmed == null and shows Data_error, preventing the user from confirming. Route the result via Fragment Result/shared state, or let this dialog submit from its persisted arguments.

    private var onMarginConfirmed: (() -> Unit)? = null

    fun setOnMarginConfirmed(callback: () -> Unit): PerpsCloseBottomSheetDialogFragment {
        onMarginConfirmed = callback
        return this

• Files reviewed: 36/36 changed files
• Comments generated: 2
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.