feat(review): implement ReviewPipeline with preview, prepare, finaliz… - #30
Merged
Merged
Conversation
…e, and SARIF export functionalities - Added ReviewPipeline class to handle review processes including previewing, preparing, and finalizing reviews. - Introduced methods for selecting review files, grouping them, resolving review rules, and anchoring findings. - Implemented support for exporting results in SARIF format. - Created policies for review efforts and configurations. - Added tests for contract validation, grouping files, and processing findings. - Developed GitHub action script to post review comments based on findings.
- Added `buildFixReviewFindingsAsk` to compile structured Mitii review findings into an Agent ask. - Introduced `fix-review-findings` skill with specific instructions for applying localized fixes. - Updated architecture documentation to reflect the new post-review mutation handling. - Enhanced the host README with details about the new skill and its usage. - Implemented tests for the new functionality to ensure correctness. - Updated agent engine to enforce structured review requirements, ensuring `emit_review_finding` is called. - Modified various components to support the new structured review process, including recovery messages and thresholds. - Improved git status handling to include both staged and unstaged changes for better review context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new deterministic code review command to the Mitii CLI, enhances documentation for the review workflow, and updates package versions. The new
mitii reviewcommand enables selection and preparation of code review findings (including SARIF export) without requiring an LLM, supporting CI and host agent use cases. Documentation and help output are updated to explain the new review capabilities and clarify usage. Additionally, a third-party attribution notice is added for the review module.Major CLI and Review Workflow Enhancements:
mitii reviewcommand, supporting deterministic review preparation and SARIF export with options for preview, diff range, commit, output format, and effort level. This includes a new implementation inrunReviewCommand.tsand integration into CLI argument parsing, help text, and command dispatch. [1] [2] [3] [4] [5] [6] [7] [8] [9]apps/cli/README.md) to describe the new review command, its options, and how to use it for deterministic review and SARIF output. [1] [2]Documentation and Attribution:
CI/CD and Versioning:
2.9.56in@mitii/cli,@mitii/acp, and@mitii/daemon, and updates the version badge in the main README. [1] [2] [3] [4]macos-15-intel(darwin-x64) in both native binaries and release pipelines. [1] [2]…e, and SARIF export functionalities