Ship systemd unit files in the Linux static tarballs - #578
Open
piyush15102003 wants to merge 1 commit into
Open
piyush15102003 wants to merge 1 commit into
piyush15102003 wants to merge 1 commit into
Conversation
The release .tgz archives only contained the binary, while the manual install docs implied cri-docker.service and cri-docker.socket were in them. Copy both units from packaging/systemd into the archive directory for the static-linux and cross-arm targets, and update the manual install page accordingly. Fixes Mirantis#249
piyush15102003
requested review from
athongsamai,
awmirantis and
smerkviladze
as code owners
September 17, 2026 20:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship the systemd unit files inside the Linux static tarballs
Closes #249.
What
packaging/static/Makefilenow copiespackaging/systemd/cri-docker.serviceandcri-docker.socketinto the archive directory beforetarruns, for both thestatic-linux(amd64) and
cross-arm(arm64) targets. The Mac and Windows archives are unchanged since theunits are Linux-only.
The manual install page is updated to say the unit files are in the archive, keeping the
wgetfrompackaging/systemdas the fallback for older releases.Why
The release
.tgzonly contained the binary, while the manual-install instructions read as ifthe unit files were in it. Anyone installing on an unsupported platform had to go find them in
the source tree separately, which is what #249 reports. The deb/rpm packages already install
these two files; the tarballs were the only distribution that left them out.
How I tested
Ran the real Makefile targets in an Alpine container with
make,bashand a stubgoonPATH(so the recipe runs end to end without a 10-minute vendored Go build):Both archives list
cri-dockerd/cri-dockerd,cri-dockerd/cri-docker.serviceandcri-dockerd/cri-docker.socket;cmpconfirms the units are byte-identical topackaging/systemd/, and they land as0644regardless of the checkout's file modes(
install -m 0644, notcp). The Go build step itself is untouched.