fix: support CR line endings in SSE - #276
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
KennyMcSimpson
marked this pull request as ready for review
October 5, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseSSEsplits only on LF. With bare CR line endings, two events such asdata: first\r\rdata: second\r\rbecome one malformed data value instead of two events. SSE permits CR, LF and CRLF as line endings.Handle all three forms, including CRLF split across network chunks. A CR completes the line immediately, so a finished event is delivered while the stream remains open. Existing field parsing and final-event flushing are preserved.
Tests
bun test— 597 passed;bun test test/client/stream.test.ts— 19 passed.bun run typecheck,bun run lintandbun run buildpass. Lint reports one existing warning intest/sdk/speech.test.ts.git diff --checkpass.Tested with Bun 1.4.2. Three new regression tests fail before the fix.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.