Repository navigation
Allow native preparation in public qualification - #590
Merged
Merged
Conversation
SaladDay
force-pushed
the
aos/qualification-preparation-budget
branch
from
October 8, 2026 17:26
3c54e51 to
2f7e24a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public qualification input submission inherited the raw HTTP client’s 30-second timeout even though the surrounding event stream allows 240 seconds. Native preparation happens before input admission returns, so the SDK request could time out while preparation continued independently. Give both Project SDK clients the existing 240-second qualification budget while preserving 30-second raw HTTP checks.
Validation: 19 qualification tests, including real pinned SDK requests through MockTransport that verify both budgets;
make check-names check-docs check-ci;git diff --check. The original live failure remains recorded; this runner change does not establish or claim a fix for the separate native preparation failure.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.