Serialize directory helper tests that open descriptors - #57
Merged
Merged
Conversation
The descriptor-count assertion in the directory tests assumes no other test in the same binary opens descriptors concurrently. The root-removal and not_directory tests added for Environment Files now take the same test lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The descriptor-count assertion in the codex-executor directory tests (
repeated_reads_release_directory_descriptors) assumes that no other test in the same binary opens descriptors concurrently. The threenot_directoryand root-removal tests added in #49 opened descriptors without the sharedTEST_LOCK. Under heavy host load, one server gate run failed on that assertion (4 vs 7 descriptors), and the poisoned lock then failed three more tests.These tests now take the same lock (poison-tolerant). This is a test-only change; runtime code is untouched.
Validation
scripts/check-agents-executor.shpasses (fmt, tests, clippy).make -o check-web checkplus Web typecheck, core-doctor, unit tests and the build all pass. The Playwright browser cases were not run on the server (no Google Chrome; the user approved the skip).No behavior change. A small follow-up to #49, so no separate review was run.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.