Fix Compose admin key validation - #410
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Compose smoke test rejected generated administrator keys after the
oac_admin_prefix was added because it still required a total length of 64 characters. Validate the prefix and exactly 64 lowercase hexadecimal characters, consistent withassertCoreKeyFormat.Validation: Python syntax, eight valid/invalid key-format cases,
git diff --check, and independent review passed. Full Compose smoke validation was unavailable locally because the Docker daemon is not running.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.