Prefix generated Core admin keys - #409
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Core administrator keys now use
oac_admin_followed by 64 lowercase hexadecimal characters. Initialization and rotation share the generator, preserving 256 bits of random entropy and hashing the complete key. Existing installed keys remain unchanged until rotated.Updated the initialization and rotation assertions, the Web authentication comment, and the English and Chinese operations documentation.
Validation:
go test ./services/core/cmd/oac ./services/web, all website translation checks, andgit diff --checkpassed. Independent review found no in-scope issues.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.