Allow plain HTTP on private networks - #408
Merged
Merged
Conversation
Grafana serves HTTP by default and treats root_url as the address browsers use. OAC_PUBLIC_URL, node Core URLs, the daemon remote_url and artifact downloads accept http or https. install.sh defaults the public URL to the host's private address so machines on the LAN can open Web. E2B still rejects a loopback public URL because its guests reach Core from the internet.
RyanLee-Dev
force-pushed
the
allow-plain-http-on-private-networks
branch
from
October 3, 2026 05:23
e4f58d5 to
24b01d6
Compare
This comment has been minimized.
This comment has been minimized.
Grafana treats root_url as the browser address, http or https. OAC_PUBLIC_URL does the same; the test still rejects paths, mixed case and other schemes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/origin: plain HTTP is allowed for loopback and literal private-network addresses (10/8, 172.16/12, 192.168/16, fc00::/7). Core'sOAC_PUBLIC_URLcheck, the node identity endpoint, the daemon'sremote_urland the Python node installer all use it;testdata/plain_http_hosts.jsonchecks the Go and Python copies. E2B still needs HTTPS.local_only. Removed the now-unusedlib/connection.ts. Copy no longer says HTTPS is required for nodes.install.sh: defaultsOAC_PUBLIC_URLtohttp://<private address>:<web port>when published on0.0.0.0, otherwisehttp://localhost:<web port>(this also fixes--web-portwithout--public-url, which left Web accepting onlylocalhost:8080). Prints step progress instead of Compose output, the services' logs on a failed start, then the console URL, the Core key (withsudoin commands when run through sudo) and next steps.Test plan
go testfor origin, deployment, node, processconfig, oac, web, daemon clipython3 -m unittestfordeploy/nodeanddeploy/test_install.pytscandvitestNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.