Stop publishing Core's admin port on the host - #406
Merged
Merged
Conversation
added 2 commits
October 3, 2026 12:13
Core only needs Docker-internal core:8091; Web is the single published entry. Operator scripts reach /core/v1 from Core's network namespace. Remove the now-unused oac healthcheck and record the conciseness rule in AGENTS.md.
Containers own data/, so the installer's failure cleanup and the documented uninstall delete its contents through the init image before removing the directory. docker cp already keeps oac's executable mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ports.yamlpublishes only Web. Core stays on the Docker-internalcore:8091; nothing on the host needs it.install.dev.shcopies the officialports.yamlinstead of writing its own.curlin Core's network namespace (--network container:<core>) and passes the Core key on stdin.oac healthcheck(compose usesoac-web healthcheck).install.sh: containers owndata/(UIDs 65532/70), so an ordinary user'srm -rffailed both in failure cleanup and in the documented uninstall. Both now cleardata/through theinitimage first. Drop the redundantchmod(docker cpkeeps the image's 0555).AGENTS.md: keep it concise, reuse existing code and standard SDKs, avoid redundant code, expose nothing without a caller.source_hashrecomputed. Dropped a stale ZH-only routing table.Test plan
python3 -m unittest deploy/compose/test_compose.py deploy/test_install.py,go test ./cmd/oac,python3 scripts/ci_plan_test.pyinstall.sh/ports.yaml: all services healthy; only Web published;/,/healthz,/docs200,/v1/files401;oac core-key --showworks; the helper creates a Project and lists harnesses