Skip to content

Give the model configuration observation fixture its placement rules - #365

Merged
RyanLee-Dev merged 2 commits into
mainfrom
fix-modelconfigurationpg-placement-fixture
Oct 1, 2026
Merged

RyanLee-Dev merged 2 commits into
mainfrom
fix-modelconfigurationpg-placement-fixture

Conversation

@RyanLee-Dev

@RyanLee-Dev RyanLee-Dev commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

backend (make check-core) has failed on every main run since #342 (ffe6734e), for example run 36815507655, which blocks every PR's required check:

--- FAIL: TestObservationExcludesOtherSourcesAndHistoricalSessions
    observation_test.go:95: session create session: hosted Session creation requires placement rules
FAIL	.../persistence/postgres/modelconfigurationpg

What changes

#342 made Store.CreateSession require placement rules for an openai_hosted Session; cmd/server supplies them through SetPlacement. The modelconfigurationpg observation fixture builds its own store.Store and was not updated, and its non-deployment cases create hosted Sessions. The fixture now calls SetPlacement with the rules cmd/server and the store fixtures build: placement.NewRules(providers.Builtin(), ""). With no deployment configured, admission passes as it does in production. Test-only change.

Checks

  • Reproduced the failure on origin/main against a local PostgreSQL with OAC_TEST_DATABASE_URL; with this change the whole modelconfigurationpg package passes.
  • go vet on the package.
  • The two Python steps of check-core that have not run in CI since the break (official_diagnostics_test.py, managed_init_test.py) pass locally.
  • The rest of the Go suite already passed in the failing CI runs; this PR's CI is the full check.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

RyanLee-Dev and others added 2 commits October 1, 2026 13:02
Since #342, Store.CreateSession requires placement rules for an
openai_hosted Session, and cmd/server supplies them through SetPlacement.
The modelconfigurationpg observation fixture builds its own Store without
them, so TestObservationExcludesOtherSourcesAndHistoricalSessions has failed
on main (backend / check-core) since ffe6734. The fixture now sets the same
rules cmd/server builds: the built-in providers and an unset public URL.
@RyanLee-Dev
RyanLee-Dev merged commit 04ab902 into main Oct 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant