Give the model configuration observation fixture its placement rules - #365
Merged
Merged
Conversation
Since #342, Store.CreateSession requires placement rules for an openai_hosted Session, and cmd/server supplies them through SetPlacement. The modelconfigurationpg observation fixture builds its own Store without them, so TestObservationExcludesOtherSourcesAndHistoricalSessions has failed on main (backend / check-core) since ffe6734. The fixture now sets the same rules cmd/server builds: the built-in providers and an unset public URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backend(make check-core) has failed on everymainrun since #342 (ffe6734e), for example run 36815507655, which blocks every PR's requiredcheck:What changes
#342 made
Store.CreateSessionrequire placement rules for anopenai_hostedSession;cmd/serversupplies them throughSetPlacement. Themodelconfigurationpgobservation fixture builds its ownstore.Storeand was not updated, and its non-deployment cases create hosted Sessions. The fixture now callsSetPlacementwith the rulescmd/serverand the store fixtures build:placement.NewRules(providers.Builtin(), ""). With no deployment configured, admission passes as it does in production. Test-only change.Checks
origin/mainagainst a local PostgreSQL withOAC_TEST_DATABASE_URL; with this change the wholemodelconfigurationpgpackage passes.go veton the package.check-corethat have not run in CI since the break (official_diagnostics_test.py,managed_init_test.py) pass locally.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.