Skip to content

Let a File call interrupt its request and still return the outcome - #353

Merged
SaladDay merged 1 commit into
feature/agent-outside-sandboxfrom
aos/fs-interrupt
Oct 1, 2026
Merged

SaladDay merged 1 commit into
feature/agent-outside-sandboxfrom
aos/fs-interrupt

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

File protocol client change, split out of #349. A FUSE frontend that gets an interrupt for a waiting lock must learn whether the lock was acquired. Cancelling the call's context abandons the response, so the outcome is lost.

  • With sandboxfs.WithInterrupt(ctx, interrupt), the client sends CancelRequest when interrupt closes and keeps waiting for the request's own response. The call returns the real result, or the service's failure with its effect.
  • Ending the context still abandons the call, as before.
  • The File access protocol doc states this in the client section.

There is no wire change. A new client test covers an interrupted request that still returns its result. go test -race ./internal/sandboxfs/... and vet pass.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@SaladDay
SaladDay merged commit 5a3a6d9 into feature/agent-outside-sandbox Oct 1, 2026
@SaladDay
SaladDay deleted the aos/fs-interrupt branch October 1, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant