Let a File call interrupt its request and still return the outcome - #353
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File protocol client change, split out of #349. A FUSE frontend that gets an interrupt for a waiting lock must learn whether the lock was acquired. Cancelling the call's context abandons the response, so the outcome is lost.
sandboxfs.WithInterrupt(ctx, interrupt), the client sendsCancelRequestwheninterruptcloses and keeps waiting for the request's own response. The call returns the real result, or the service's failure with its effect.There is no wire change. A new client test covers an interrupted request that still returns its result.
go test -race ./internal/sandboxfs/...and vet pass.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.