Derive the serve peer's identity from its credential - #344
Merged
Merged
Conversation
ServeHello no longer carries a PeerID: the serve side has no source for it and the credential already identifies the peer. The relay checks only the Hello's Resource against the Authority's ServePeer, which still returns the peer's identity. Updates the codec, validation, serve config, relay, tests, golden frames and the Link protocol document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link protocol change: the serve peer's identity now comes only from its credential.
ServeHello.PeerIDhad no source on the serve side, because the Sandbox I/O bootstrap carries no peer ID, and the relay only compared it with the Authority's answer. The Hello now carries no peer ID. The Authority still returnsServePeer{PeerID, Resource}for the credential, and the relay requires onlyResourceto equal the Hello's.internal/sandboxlink: theServeHellotype, its codec and validation,ServeConfig, the relay check, and the golden frames intestdata/link_v1.hex.docs/sandbox-link-protocol.md: the Hello listing and the serve-peer Authority rule.Checks:
go test -raceon link, relay and bootstrapFuzzDecode, 20 sPart of the agent-outside-sandbox work, milestone M1. Found while assembling
oac-sandbox-io(lane L3b).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.