Wait for server-side lease release in test handoffs - #326
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store restart tests can acquire a successor lease before PostgreSQL has released the previous session's advisory lock.
Lease.Closewaits for client cleanup, as documented; it does not acknowledge server-side lock release.Move the existing owner-specific release observer into shared
pgtestsupport and use it at the internal Store tests that immediately transfer ownership. Existing Worker handoff tests use the same helper. Observation is bounded, rejects query errors and never retries lease acquisition. Production lease behavior and deadlines are unchanged.Validation:
776a9414f2d1eaf2ee01eec94a40c29791650b10: backend, API acceptance, hygiene and the required check (run 36757020221). Temporary PostgreSQL containers, volumes and remote test files were removed.This is separate from the CI architecture changes in #324.