Move Vaults and Credentials out of store into vaults and vaultpg - #319
Merged
Merged
Conversation
The api handlers, the Session credential binding and the Dispatcher's MCP bearer lookup use the vaults service and the vaultpg adapter. The Vault and Credential code and tests leave store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1 (store layering), PR 5: Vaults and Credentials move out of
store.vaultsdomain package:Servicefor create, update, delete, OAuth replace/refresh,ResolveMCPCredentialsandMCPBearerTokenStorage/Reader/OAuthTxportspersistence/postgres/vaultpg: the PostgreSQL adapter.auditpg.Vaults(service) andVaultsReader(adapter) Dependencies fields, strict fakes, and the vaults error writer.vaults.MCPCredentialBinding. The Worker opens bearer tokens through an explicitDispatcher.Credentialsport and no longer reaches intostore.StartWorkerrequiresCredentials.cmd/server: wiresvaultpg.New(units)andvaults.NewService(store, key, oauthClient).storeno longer takes the OAuth client.store: the vault, credential, OAuth and MCP credential files and their tests. Coverage moved tovaults/vaultpg.Behaviour changes:
Checks on the final head (d34e791 + 2):
go build ./...andgo vet ./services/core/...across the whole modulevaultsandvaultpgin full, including the OAuth refresh race testscmd/serverandsandbox/providers: the affected tests, by-runstore: by-runonly (the audit and MCP credentialpublicHandlertests)make openapi(no diff) andscripts/check-names.pyNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.