Pass Agent stand-ins to the provider configuration flow test - #317
Merged
Merged
Conversation
The flow never reaches Agents, and *store.Store no longer implements api.Agents, so go vet failed on the providers test package. Give it stand-ins that panic if called, as for the other unused dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
go vet ./services/core/...on main after #315. The provider configuration flow test still passed*store.Storeasapi.Agents, and store no longer implements it. That flow never touches Agents, so the test now passesstruct{ api.Agents }{}andstruct{ api.AgentsReader }{}, which panic if called.Checks:
go vet ./services/core/...exits 0 across the module, andgo test ./services/core/internal/sandbox/providers/...passes 36 tests with 0 skipped.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.