Fix the retirement failure test deadline race - #314
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retirement failure test blocks an owner query and waits for a later cancellation fence to time out. Both operations have the same five-second lease deadline, so the query's own deadline can expire before the fixture releases it. A ten-second outer query context cannot extend that bound.
Give only the fixture's cancellation attempt a shorter caller deadline, still using the real PostgreSQL lease. Preserve admission, lifecycle retention and drain assertions, and verify the lease remains usable after releasing the query. Clear the consumed result before reporting failure so cleanup does not wait for it twice. Production code and deadlines are unchanged.
Validation against an isolated PostgreSQL 16 database on Linux:
git diff --checkpassed. A fresh independent blind reviewer found no issues and independently passed the target test 20 times with the race detector against PostgreSQL.