Harden self-hosted Runtime installation and interrupted recovery - #310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-hosted Runtime installation currently fails immediately on transient downloads and leaves interrupted staging behind. Bound and retry downloads, check available space, report useful filesystem errors, and recover unfinished staging without replacing completed components, credentials or workspaces. Add terminal progress and preserve plain redirected output.
Validation:
Independent blind review of the full diff passed after the identified issues were fixed and covered by regression tests. Native CI passed on the final commit (
be18a6deaf70d3a55a7f359474c330914afbc95a). Managed sandbox startup, node installation and Core/Web installation are outside this change.