Remove Dispatcher.Options and legacy daemon Sessions - #299
Merged
Merged
Conversation
Dispatcher.Options was a second, test-only source of native adapter options for Sessions without a frozen model provider. Delete it: a Session without a frozen provider now always gets only its Agent model and instructions, as in production. Production never writes a "daemon" Session configuration, so delete the legacy daemon Session path with it: Snapshot.Daemon, DaemonConfig, the work_dir resolution in Run and the hasDaemon parameter of the engine profile validators. Run executes only environment:none Sessions. Tests move onto the declared configuration path. The store dispatch harness creates environment:none Sessions. Native tests serve their synthetic model over HTTPS with a test CA the daemon trusts through CODEX_CA_CERTIFICATE, and freeze it as the deployment default model provider, either at Session creation or through the public API's deployment defaults. Real-model opt-in tests read their private file as that deployment default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispatcher.Optionswas a test-only second source of native adapter options for Sessions without a frozen model provider. Production never set it. This deletes it, along with the legacy daemon Session path it served. Production never writes adaemonSession configuration.Deleted
Dispatcher.Optionsand its branch inexecution/request.go.Snapshot.Daemon,DaemonConfig, the daemon half ofresolveExecutionEnvironment, and thehasDaemonparameter ofengine.Profile.ValidateConfiguration,ValidateToolsandValidateMCPOrigins.Runaccepts onlyenvironment: noneSessions. The one predicateenvironmentNoneservesRun, input admission and the capability check.Tests move onto the declared configuration path
CODEX_CA_CERTIFICATE; the daemon and adapter code are unchanged.{model, model_provider}(documented inharness-onboarding.md).enable_features/model_verbosity/web_searchinputs are gone, because Core can no longer send them. The precedence rule is still covered by the daemon codex testsTestExecutionControlsOverrideWithoutMutatingNativeOptionsandTestDisableSubagentsOverridesNativeFeaturePreferences.TestExecutionRejectsLegacyDaemonBeforeClaimbecomesTestExecutionRejectsRuntimeMissingCapabilityBeforeClaim. Each subtest now fails on its own capability, and there are newpreparationandenvironment_nonecases.Behaviour changes
noneSession reachingRungetsErrInvalidInput.WorkDir. Adaemonkey in a Session configuration has no effect.Checks
go build ./...passes.go vetpasses on execution, engine and api.go test -p 1on engine, execution, cmd, api and store against PostgreSQL, with the native daemon and the pinned SDK: 2854 passed, 0 failed, 9 skipped. The skips are opt-in real-model and operator-binary tests. 452 DB-backed tests ran.check-names.pyand the markdown link test pass.WorkDirmoves off the Core–Runtime wire in a follow-up Runtime–Harness PR.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.