Use httpx2 in the remaining official-client scripts - #298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned official SDK (openai 3.13.0) depends on
httpx2, and every other script inservices/core/testsalready imports it.official_skills.py,official_skill_selectors.pyandofficial_admin_management.pystill importedhttpx, so they failed withModuleNotFoundErrorin an environment set up fromrequirements.txtand the pinned SDK.Verified with a python that has the pinned SDK and no
httpx:TestSkillsOfficialClientPostgresandTestSkillSelectorsOfficialClientPostgresran against PostgreSQL and passed.official_admin_management.pytargets a deployed Core and has no Go test; it compiles.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.