Remove remaining retired names - #294
Merged
Merged
Conversation
- Copyright holder is the MiniMax-AI organization; the name guard now rejects the retired MiniMax-AI-Dev organization. - Describe RunID as the Core Turn ID and the runtimecrypto wire fixture as the Runtime credential envelope fixture (description text only; sealed bytes unchanged). - Drop the legacy /.parsar/ ignore rule, retired-name test inputs and retired example container names. - Remove name-guard exceptions that no longer excuse anything and narrow the product-setting and phrase exceptions to the text still present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rename to OpenAgentCore left a few retired names that are neither preserved data nor references to the separate Parsar product. This removes them and tightens the name guard so they don't come back.
LICENSEandexample/parsar/LICENSE: copyright holderMiniMax-AI-Dev→MiniMax-AI, the GitHub organization.check-namesnow rejectsminimax-ai-devin any case.internal/agentdaemon/proto/outbound.go: theRunIDcomment names what Core sends, the Core Turn ID (execution/dispatcher.go,prepared_dispatch.go).internal/runtimecrypto: fixture description text only; the sealed bytes are unchanged and no test reads the description..gitignore: drop/.parsar/.PARSAR_MASTER_KEY(credential cipher),PARSAR_APPLICATION_VALUE(Environment setup),parsar-core-runtime@(Web Runtime reference). The remaining cases still cover current behavior..env.exampleand the Web Docker guide test useoac-web-smoke-*container names, matching the existingoac-web-smoke-db.scripts/name-allowlist.json: remove the exceptions that no longer excuse anything and narrow the rest to the text still present.Unchanged on purpose: credential encryption domains, the
agents-api-Session state-key namespace and landed migrations (existing data must decrypt and Sessions must resume), references to the separate Parsar product and the example, and the daemon'sskill_uploadproduct integration (open question).Checks run (focused):
check-names.pyandcheck-names.test.py;go testonservices/core/cmd/server(TestCredentialCipherConfiguration),internal/runtimecrypto/...,internal/agentdaemon/proto/...andservices/core/internal/store -run TestEnvironmentSetup;go veton the touched packages;go build ./...;pnpm install --frozen-lockfile,pnpm typecheckand vitest on the two touched Web test files.Review: no blind review. This is a small change to comments, test inputs and the name guard; the coordinator read the full diff.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.