refactor: bind Runtime observation identity to its declared source - #292
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime observation identity was discovered through an optional method on a mutable source, allowing an empty identity or identity from a different provider selection than the read. The observation contract now requires a validated identity and explicitly resolves one stable source for each page. Unconfigured startup remains typed unavailability, while retained-generation routing keeps its ownership checks.
A fresh independent reviewer found no blocking issues. Focused observation/provider/server tests, race tests, full execution tests and selected database-backed store consumers passed, along with full Go build and name guard. Touched-package vet passed except the two unchanged store fixture copylocks at environment_runtime_fixture_test.go:40 and environment_work_test.go:62. Relevant checks passed again after rebasing onto current main. No live-provider qualification or full
make checkwas run.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.