refactor: declare cancellation receipts for every session owner - #289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispatch could omit cancellation receipts because it discovered the outcome method through a private optional interface. The Runtime–Harness Session contract now requires the observed outcome snapshot for every cancellation owner, including Turns and executable preparations. Dispatch reads the same captured owner it cancelled; the protocol documents request, observed evidence and confirmed settlement separately.
A fresh independent review found no blocking issues. Focused agent/adapter, dispatch and wire contract tests, cancellation/settlement race tests, full Go build, affected vet and name guard passed. Relevant tests passed again after rebasing onto current main. Native adapter behavior and settlement waits are unchanged; no full gate or live-model qualification was run.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.