refactor: declare provider artifacts and installed process paths - #287
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node payload lists were authored separately by Web, packaging and installation, and the E2B adapter read process environment variables itself. Provider registrations now declare validated artifact roles and paths, with generated Go/JSON and Python projections consumed by those callers. Core supplies fixed installed artifact/state roots to construction and discovery; E2B resolves its private paths inside its adapter.
Two independent reviews completed. The first found the isolated Core build omitted the new shared package; its source bundle was corrected and the actual isolated build produced all five Core commands. A fresh second review found no blocking issues.
Validation: focused provider/E2B/server/Web Go tests, affected build/vet checks, isolated database tests, generated declaration freshness, installer/configuration/manifest tests, distribution checks and name guard. E2B helper tests used the pinned SDK and synthetic fixtures; no live cloud qualification is claimed. Final projection, provider/E2B/Web tests and shell syntax checks passed after rebasing onto current main. No full
make checkwas run under the requested focused workflow.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.