Check node diagnostic codes across Core and Web - #282
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node readiness codes were copied independently across Core, OpenAPI annotations, the client and Web. Check those projections against one shared diagnostic fixture, derive the client type from its checked code tuple, and have Web reuse the client normalizer. Known codes and localized advice are preserved; unknown codes still become
provider_unavailable.Validation: focused Go diagnostic/schema conformance tests,
go build ./..., sandbox vet, workspace typecheck, 76 client tests, 19 Web tests and name guard passed. Store-wide vet reports two pre-existing mutex-copy warnings in environment fixture tests; this change adds no production Go code and does not modify those fixtures. The small consolidation was self-reviewed under the requested focused-check workflow.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.