chore: remove obsolete scripts and unify Core image packaging - #279
Merged
Merged
Conversation
scripts/verify-source-copy.py checked byte identity with the original import and no longer passes; nothing runs it. Remove it with provenance/, the CONTRIBUTING audit-trail sentence and their name-guard exceptions.
scripts/core-doctor.mjs had no caller besides its own test. The Vite /v1 proxy, its bearer token file (~/.oac/dev/web-token) and the __OAC_WEB_DEV_PROXY_AUTH__ flag existed only for it; the console never calls /v1. The browser acceptance guard now records /v1 requests in the browser, since the development server no longer forwards them.
No workflow ran them, they needed a private package and host, and they rejected install.sh, so a promoted Release would lack the public bootstrap. release.yml with publish-core-release.py publishes every Release.
No workflow built it and no Release carried it; it repackaged the make build-core commands. Remove build-core-release.sh, its Make target, the archive README and the documentation that described it.
check-core-container ran the read-only official-client suite against an image built from services/core/Dockerfile, which no release ships. Build the Core image context in scripts/build-core-image-context.sh, which the distribution builder now also calls, and have docker-build-core build deploy/distribution/Dockerfile from it. Delete build-core-image.sh, the standalone Dockerfile and the guide for running the standalone container.
Nothing ran scripts/core-subagents-acceptance.py; Go store and API tests cover the Subagent read rows. Drop the sentences in the Subagent contract that described the script.
make check-database no longer checks for PARSAR_AGENTS_API_TEST_DATABASE_URL; it only requires OAC_TEST_DATABASE_URL.
build-core.sh and build-web.sh now say Core and Web in their messages. Drop the command-line entry of build-native-installer.mjs, which only build-native-installer-ci.mjs and its test import, and the --only option of native-harness-smoke.mjs, which native.yml never passes.
check-names.py now reports every allowlist exception that excuses no retired identifier, whether it matches no file, matches only allowed text or outlived the text it covered. Remove the ten such exceptions, including the case-mismatched X-Core-Console-Actor, and two exceptions that other rules already cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove obsolete development and release paths before publication: source-copy provenance, core-doctor and its unused Web application-API proxy, standalone Core archive/image packaging, manual Subagent acceptance, and the qualification/promotion chain. Container acceptance now builds the distribution's Core image through the same context helper. The name guard rejects exceptions that no longer excuse a match.
Independent review found no significant issues. Relevant validation passed: name guard, distribution/installer suite, native bundle tests, Vite configuration, shell syntax, and all six access browser scenarios (one transient failure passed on rerun). All five Core commands built. Full image/container acceptance could not complete locally because the existing E2B builder cannot reach the host's proxy from Docker; the dedicated database/pinned SDK prerequisites are also unavailable in this shell. No live model qualification is claimed.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.