Remove retired setting diagnostics and product-derived Web names - #277
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core, Runtime and Web still recognized superseded settings and headers solely to print replacement diagnostics. Delete those tables and their dedicated fixtures so current settings and ordinary unknown-field validation define the boundary. Remove the obsolete heartbeat-metadata fixture, rename private Web patch parser/CSS symbols, and update the affected documentation and name-guard exceptions.
Validation:
go build ./...;go vetandgo testfor the affected CLI, logging, gateway, Web, Core server, node, API and database URL packages (follow-up API/server/node/databaseurl tests rerun with an explicitly configured dedicated PostgreSQL database, all passed); frozen pnpm install and workspace typecheck; 22 focused Web tests; name guard; shell syntax;make -n check; diff whitespace check. Focused validation follows the requested workflow. This deletion/rename change was self-reviewed; independent review is reserved for the separate protocol changes.