Delete pre-rename node refusal and legacy generation handling - #274
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The project is not public, so it keeps no backward compatibility. Pre-rename detectors, hints and conversion code are deleted. Another session is cleaning the rest of the repository; this PR covers the node installer. Installer and
oaclegacy code follows in a later PR, after the in-flight installer PRs merge.What
node_install.pyloses the pre-rename node refusal: old/etc/parsar-noderecords,/var/lib/parsar-node,parsar-node-<id>.serviceunits,~/.parsar/nodespaths andparsar-node-<id>networks. It also loses the retiredPARSAR_NODE_ENROLLMENT_TOKENcheck.node_generations.pydrops thelegacy-unfencedv1 generation marker, andcontracts/agents-api/node-generation-protocol.mddrops its description.test_node_legacy.pyis deleted, along with the legacy cases intest_node_install.pyandtest_node_generations.py, and the matchingscripts/name-allowlist.jsonentries.Removal only; current behavior is unchanged. No blind review: a pure deletion, read in full by the coordinator (remaining imports still used, no dangling doc references).
Checks
Focused:
make check-distribution(234 installer tests OK, 1 skipped as on main) andmake check-namespass.git grep -i -E "parsar|legacy.unfenced|PARSAR_NODE" -- deploy/install/node_* deploy/install/test_node_*finds nothing.