Move daemon placement under apps/daemon/internal - #273
Merged
Merged
Conversation
Only the daemon's placement command uses the placement package, so it belongs with the daemon rather than in the shared internal tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/holds code that both Core and the daemon use.internal/agentdaemon/placementis used only by the daemon, so it moves toapps/daemon/internal/placement. This is a puregit mv; the only other change is its one importer.internal/agentdaemon/{proto,gateway,device}stay.gatewayanddeviceare shared too: the daemon's wire contract test (apps/daemon/internal/contracttest) runs Core's production gateway against the production daemon transport, and Go's internal-package rule prevents that test from importingservices/core/internal.Checks run (focused):
go build ./...;go veton the moved package and its importer (linux, darwin, windows);go testonplacement,cliandcontracttest;check-names.Review: a fresh subagent blind-reviewed the diff and found nothing at P0–P3.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.