fix: align every surface with current model, preparation and image rules - #254
Merged
Merged
Conversation
Behavior is taken from code and tests. Where another surface disagreed, the surface was wrong: - Inline openai_hosted/none Sessions may omit agent.model and use the deployment default (session_model_configuration.go, "provider replaces native defaults" test). execution-configuration.md said there was no implicit deployment default; it now links to model-execution.md. - The inline-model error names the deployment-default exception. - Web "How to call" note says the model field may be removed to use the default and that self-hosted never uses it; drop the unused inlineModelRequired strings. - Agents API guide: add x_agents_core.environment (portable preparation for either placement, #246), templates usable by self-hosted Sessions, image input no longer limited to none/Docker (#247), and state that disabled or restricted networks are stored but rejected at execution because no current Runtime enforces them. The template example no longer uses a restricted network. - Parsar example: its error and README say the example, not Core, declines managed Skills on user machines. Add a repo-wide retired-claim check to verify-docs-facts.mjs so these statements cannot return in docs, contracts, OpenAPI, Web copy or Go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior is taken from code and tests. Every surface that disagreed with them was fixed.
Model can be omitted
Evidence:
session_model_configuration.go:51and theprovider replaces native defaultstest.contracts/agents-api/execution-configuration.mdsaid "no implicit deployment default". It now links tomodel-execution.md, the owner.inlineModelRequiredstrings are removed.Agents API guide, after #246/#247/#251
x_agents_core.environment: portable preparation for any placement. Self-hosted Sessions can use templates.none/Docker.disabledandrestrictednetworks are stored but rejected at execution, because no current Runtime enforces them. The template example no longer usesrestricted.connection_origintable.serviceworks onnonewith Codex and Claude Code;environmentworks in workspaces with all three harnesses.Parsar example
The error message and README now say the example declines managed Skills on user machines. Core itself supports them.
Guard
verify-docs-facts.mjsnow scans all tracked docs, contracts, OpenAPI, Web copy and Go for retired claims, and fails with a pointer to the current owner. Verified both ways: it passes on this branch and fails when the oldexecution-configuration.mdis restored.Validation
check-docs,check-names,check-harness-catalogandcheck-examplepass.go buildandgo vetpass, andgo test ./services/agents-api/internal/api/passes.check-web: 756 unit tests and 451 component tests pass; 85 of 86 e2e tests pass. The one failure,sandbox-generation.spec.ts:50, timed out in the full run and passed 3 out of 3 reruns on its own. It is unrelated to this change.check-database,check-agents-apiand other targets that need Docker or PostgreSQL, which are unavailable on this machine.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.