Skip to content

fix: align every surface with current model, preparation and image rules - #254

Merged
SaladDay merged 2 commits into
mainfrom
docs/model-omission-consistency
Sep 30, 2026
Merged

SaladDay merged 2 commits into
mainfrom
docs/model-omission-consistency

Conversation

@SaladDay

@SaladDay SaladDay commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Behavior is taken from code and tests. Every surface that disagreed with them was fixed.

Model can be omitted

Evidence: session_model_configuration.go:51 and the provider replaces native defaults test.

  • contracts/agents-api/execution-configuration.md said "no implicit deployment default". It now links to model-execution.md, the owner.
  • The inline-model error now names the deployment-default exception.
  • The Web How to call note (en/zh) says the model field can be removed to use the default, and that self-hosted Sessions never use it.
  • The unused inlineModelRequired strings are removed.

Agents API guide, after #246/#247/#251

  • Adds x_agents_core.environment: portable preparation for any placement. Self-hosted Sessions can use templates.
  • Image input works on any Runtime that supports images (Codex and Claude Code). It is no longer limited to none/Docker.
  • disabled and restricted networks are stored but rejected at execution, because no current Runtime enforces them. The template example no longer uses restricted.
  • MCP: connection_origin table. service works on none with Codex and Claude Code; environment works in workspaces with all three harnesses.

Parsar example

The error message and README now say the example declines managed Skills on user machines. Core itself supports them.

Guard

verify-docs-facts.mjs now scans all tracked docs, contracts, OpenAPI, Web copy and Go for retired claims, and fails with a pointer to the current owner. Verified both ways: it passes on this branch and fails when the old execution-configuration.md is restored.

Validation

  • check-docs, check-names, check-harness-catalog and check-example pass.
  • The link check reports 0 broken links in 114 files.
  • go build and go vet pass, and go test ./services/agents-api/internal/api/ passes.
  • check-web: 756 unit tests and 451 component tests pass; 85 of 86 e2e tests pass. The one failure, sandbox-generation.spec.ts:50, timed out in the full run and passed 3 out of 3 reruns on its own. It is unrelated to this change.
  • Not run: check-database, check-agents-api and other targets that need Docker or PostgreSQL, which are unavailable on this machine.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Behavior is taken from code and tests. Where another surface disagreed, the
surface was wrong:

- Inline openai_hosted/none Sessions may omit agent.model and use the
  deployment default (session_model_configuration.go, "provider replaces
  native defaults" test). execution-configuration.md said there was no
  implicit deployment default; it now links to model-execution.md.
- The inline-model error names the deployment-default exception.
- Web "How to call" note says the model field may be removed to use the
  default and that self-hosted never uses it; drop the unused
  inlineModelRequired strings.
- Agents API guide: add x_agents_core.environment (portable preparation for
  either placement, #246), templates usable by self-hosted Sessions, image
  input no longer limited to none/Docker (#247), and state that disabled or
  restricted networks are stored but rejected at execution because no current
  Runtime enforces them. The template example no longer uses a restricted
  network.
- Parsar example: its error and README say the example, not Core, declines
  managed Skills on user machines.

Add a repo-wide retired-claim check to verify-docs-facts.mjs so these
statements cannot return in docs, contracts, OpenAPI, Web copy or Go.
@SaladDay
SaladDay merged commit 4f25d37 into main Sep 30, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant